Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10831021: Added a test of Dart_FunctionParameterCounts against a closure inside an (Closed)

Created:
8 years, 5 months ago by rmacnak
Modified:
8 years, 5 months ago
Reviewers:
srdjan, siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added a test of Dart_FunctionParameterCounts against a closure inside of an instance method. It currently gives the wrong answer for the fixed parameter count because the closure's function is identified as non-static => instance => one implicit parameter (receiver) in Function::NumberOfImplicitParameters. Committed: https://code.google.com/p/dart/source/detail?r=9956

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 3 chunks +115 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
8 years, 5 months ago (2012-07-26 00:37:31 UTC) #1
Ivan Posva
https://chromiumcodereview.appspot.com/10831021/diff/4001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://chromiumcodereview.appspot.com/10831021/diff/4001/runtime/vm/dart_api_impl_test.cc#newcode3722 runtime/vm/dart_api_impl_test.cc:3722: " return (){return this;};\n" Please add spaces between (), ...
8 years, 5 months ago (2012-07-26 01:01:09 UTC) #2
rmacnak
Fixed spacing in closure literals. Added cases for instance closure with fixed and opt params, ...
8 years, 5 months ago (2012-07-26 01:25:00 UTC) #3
Ivan Posva
8 years, 5 months ago (2012-07-26 18:26:54 UTC) #4
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698