serve api docs from cloud storage

serve api docs from cloud storage


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9908

[sethladd, 2012-07-25 03:23:16]

PTAL. Thanks!

[nweiz, 2012-07-25 18:50:49]

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/app.yaml (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/app.yaml:6: version: changeme
What's up with this?

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/scripts/redirector.py (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:5: from __future__ import
with_statement
I think Python 2.7 supports with with statement natively.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:13: from google.appengine.api
import memcache
from google.appengine.api import files, memcache

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:16: NEXT_DOC_VERSION_CHECK = None
I believe only constants should be written in all caps. Since these change over
time, they should probably be class variables.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:24: def load_latest_version(self):
Calling this reload_latest_version would make it clearer what the difference is
between it and get_latest_version.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:36: if forced_reload != '' or \
"!= ''" here is unnecessary, since '' is falsey in Python.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:38: NEXT_DOC_VERSION_CHECK == None
or \
Similarly, I think it's better to use "not <varname>" here rather than
explicitly comparing them to a value.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:45: age = ONE_DAY
Slightly cleaner to say "return ONE_DAY" rather than assigning to a variable and
returning that.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:83: with files.open(path, 'r') as
f:
Since you're just checking for an ExistenceError, files.open(...).close() would
be a little cleaner than using with.

[sethladd, 2012-07-25 20:48:45]

please take another look. thanks!

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/app.yaml (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/app.yaml:6: version: changeme
We roll the version on every deploy. I could leave this blank.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/scripts/redirector.py (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:5: from __future__ import
with_statement
On 2012/07/25 18:50:49, nweiz wrote:
> I think Python 2.7 supports with with statement natively.

Done.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:13: from google.appengine.api
import memcache
On 2012/07/25 18:50:49, nweiz wrote:
> from google.appengine.api import files, memcache

Done.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:16: NEXT_DOC_VERSION_CHECK = None
Good call. Done.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:24: def load_latest_version(self):
I like it. Done.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:36: if forced_reload != '' or \
I was trying to be more explicit, but I can be more pythony.

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:38: NEXT_DOC_VERSION_CHECK == None
or \
I talked to a Python guy here and he said to use "foo is None"

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:45: age = ONE_DAY
I'm partial to how it is, all things being equal. is this bad python style?

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:83: with files.open(path, 'r') as
f:
Yeah, that's nicer.

[nweiz, 2012-07-25 20:58:03]

lgtm

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/app.yaml (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/app.yaml:6: version: changeme
On 2012/07/25 20:48:45, sethladd wrote:
> We roll the version on every deploy. I could leave this blank.

What do you mean by "roll the version"? Why isn't this 18?

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/scripts/redirector.py (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/scripts/redirector.py:45: age = ONE_DAY
On 2012/07/25 20:48:45, sethladd wrote:
> I'm partial to how it is, all things being equal. is this bad python style?

I dunno if it's bad style for Python in particular, but I tend to prefer
short-circuiting returns and fewer lines of code in general.

[sethladd, 2012-07-25 21:02:13]

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
File utils/apidoc/app_engine/app.yaml (right):

https://chromiumcodereview.appspot.com/10831002/diff/6001/utils/apidoc/app_en...
utils/apidoc/app_engine/app.yaml:6: version: changeme
because both kathy and I deploy, so we use sethladd-XX and kathyw-XX as
versions.