Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830359: dart2dart Fix collecting type of class fields (Closed)

Created:
8 years, 4 months ago by Roman
Modified:
8 years, 4 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2dart Fix collecting type of class fields Committed: https://code.google.com/p/dart/source/detail?r=10835

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M lib/compiler/implementation/dart_backend/backend.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roman
8 years, 4 months ago (2012-08-16 16:26:13 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode174 lib/compiler/implementation/dart_backend/backend.dart:174: if (rootElement is VariableElement) { let's do that in ...
8 years, 4 months ago (2012-08-16 16:27:47 UTC) #2
Roman
https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode174 lib/compiler/implementation/dart_backend/backend.dart:174: if (rootElement is VariableElement) { On 2012/08/16 16:27:47, Anton ...
8 years, 4 months ago (2012-08-16 16:33:54 UTC) #3
Anton Muhin
8 years, 4 months ago (2012-08-16 16:35:51 UTC) #4 
lgtm

https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10830359/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:174: if (rootElement is
VariableElement) {
Caller might be the better place, but up to you

On 2012/08/16 16:33:54, Roman wrote:
> On 2012/08/16 16:27:47, Anton Muhin wrote:
> > let's do that in ctor or in caller, ok?
> 
> Done. Ternary expression in initializer does not look very nice, but element
is
> final.

Powered by Google App Engine
This is Rietveld 408576698