Issue 10830356: Fix the order in which elements are emitted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830356: Fix the order in which elements are emitted. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the order in which elements are emitted. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10829

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -22 lines)			Patch
M	lib/compiler/implementation/dart_backend/backend.dart	View		4 chunks	+24 lines, -8 lines	1 comment	Download
M	lib/compiler/implementation/dart_backend/emitter.dart	View		4 chunks	+9 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View	1	4 chunks	+29 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Roman

8 years, 4 months ago (2012-08-16 15:23:14 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10830356/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10830356/diff/2001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/backend.dart:108: compareElements(e0,
e1) {
I miss SortedSet now

Expand Messages | Collapse Messages