Issue 10830302: Add python script for clobbering the output directory of a build on any platform given the mode and…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830302: Add python script for clobbering the output directory of a build on any platform given the mode and… (Closed)

Created:
8 years, 4 months ago by ricow1

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add python script for clobbering the output directory of a build on any platform given the mode and architecture. Committed: https://code.google.com/p/dart/source/detail?r=10629

Patch Set 3 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -0 lines)			Patch
	A	tools/clean_output_directory.py	View	1 2	1 chunk	+60 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ricow1

https://chromiumcodereview.appspot.com/10830302/diff/4001/tools/clean_output_directory.py File tools/clean_output_directory.py (right): https://chromiumcodereview.appspot.com/10830302/diff/4001/tools/clean_output_directory.py#newcode27 tools/clean_output_directory.py:27: def ProcessOptions(options): This is verbatim copy of the ProcessOptions ...

8 years, 4 months ago (2012-08-14 09:27:41 UTC) #1

ahe

LGTM, but I think we should use the external Google Python style guide for new ...

8 years, 4 months ago (2012-08-14 10:09:34 UTC) #2

ricow1

8 years, 4 months ago (2012-08-14 11:33:09 UTC) #3

As discussed offline I will stay with the current style for now

Expand Messages | Collapse Messages

Issue 10830302: Add python script for clobbering the output directory of a build on any platform given the mode and… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages