Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 10830247: Filter out _android.(cc|h) files for non-Android OS targets (Closed)

Created:
8 years, 4 months ago by jackpal
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Filter out _android.(cc|h) files for non-Android OS targets This change allows us to add _android.(cc|h) files to the source tree without affecting other OSs. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gyp/source_filter.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jackpal
Patch 1 of 6 for building Dart VM for Android This is a very small ...
8 years, 4 months ago (2012-08-09 18:04:44 UTC) #1
Emily Fortuna
lgtm
8 years, 4 months ago (2012-08-09 20:04:15 UTC) #2
Ivan Posva
LGTM -ip
8 years, 4 months ago (2012-08-09 20:13:44 UTC) #3
ahe
LGTM!
8 years, 4 months ago (2012-08-09 20:42:33 UTC) #4
Søren Gjesse
8 years, 4 months ago (2012-08-10 07:11:14 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698