Issue 10830191: Add ArchiveInputStream.readAll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830191: Add ArchiveInputStream.readAll. (Closed)

Created:
8 years, 4 months ago by nweiz

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add ArchiveInputStream.readAll. Committed: https://code.google.com/p/dart/source/detail?r=10325

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -3 lines)			Patch
M	utils/archive/entry.dart	View	2 chunks	+35 lines, -0 lines	2 comments	Download
M	utils/archive/entry_request.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/archive/input_stream.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	utils/archive/utils.dart	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	utils/tests/archive/reader_test.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	utils/tests/archive/utils_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM https://chromiumcodereview.appspot.com/10830191/diff/1/utils/archive/entry.dart File utils/archive/entry.dart (right): https://chromiumcodereview.appspot.com/10830191/diff/1/utils/archive/entry.dart#newcode208 utils/archive/entry.dart:208: * This may not be called [openInputStream] is ...

8 years, 4 months ago (2012-08-06 23:44:28 UTC) #2

nweiz

8 years, 4 months ago (2012-08-07 00:57:12 UTC) #3

https://chromiumcodereview.appspot.com/10830191/diff/1/utils/archive/entry.dart
File utils/archive/entry.dart (right):

https://chromiumcodereview.appspot.com/10830191/diff/1/utils/archive/entry.da...
utils/archive/entry.dart:208: * This may not be called [openInputStream] is
called, and vice versa.
On 2012/08/06 23:44:28, Bob Nystrom wrote:
> Missing some word here.

Done.

Expand Messages | Collapse Messages