Ability to guard callbacks that may never get called.

Ability to guard callbacks that may never get called (protectAsync*), and simplified and improved handling of exceptions.
Committed: https://code.google.com/p/dart/source/detail?r=10152

[gram, 2012-08-01 23:25:17]

BTW this is my modified version of your example that now works:


void testOne() {
    var f = expectAsync0(() {});
    window.setTimeout(protectAsync0(() => expect(false)), 0);
    window.setTimeout(protectAsync0(() => expect(false)), 0);
}

void testTwo() {
    window.setTimeout(expectAsync0(() {}), 60);
}

void main() {
  useHtmlConfiguration();
  test('one', testOne);
  test('two', testTwo);
}

[gram, 2012-08-02 00:00:20]

Okay, now you can take a look. Your example will work with expectAsync0 or
protectAsync around the timeout callbacks.

[Siggi Cherem (dart-lang), 2012-08-02 00:19:07]

can we add the test to keep it working in the future?

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart
File lib/unittest/unittest.dart (right):

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart#...
lib/unittest/unittest.dart:359: _init(callback, _always, _never, 0);
seems that _never will never be used anywhere else :), I'd just inline the
definition here:
_always, () => false /* is never done */ , 0

(especially since _always and _never below are totally unrelated)

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart#...
lib/unittest/unittest.dart:766: if (testNum == _currentTest) {
yay!

[gram, 2012-08-02 00:41:32]

Test added

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart
File lib/unittest/unittest.dart (right):

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart#...
lib/unittest/unittest.dart:359: _init(callback, _always, _never, 0);
On 2012/08/02 00:19:07, sigmund wrote:
> seems that _never will never be used anywhere else :), I'd just inline the
> definition here:
> _always, () => false /* is never done */ , 0
> 
> (especially since _always and _never below are totally unrelated)

Done.

http://codereview.chromium.org/10830128/diff/4001/lib/unittest/unittest.dart#...
lib/unittest/unittest.dart:766: if (testNum == _currentTest) {
On 2012/08/02 00:19:07, sigmund wrote:
> yay!

Done.

[Siggi Cherem (dart-lang), 2012-08-02 00:42:09]

lgtm

http://codereview.chromium.org/10830128/diff/5002/tests/lib/unittest/unittest...
File tests/lib/unittest/unittest_test.dart (right):

http://codereview.chromium.org/10830128/diff/5002/tests/lib/unittest/unittest...
tests/lib/unittest/unittest_test.dart:191: buildStatusString(1, 0, 1, 'testOne',
message: 'Callback called after already being marked as done (1).:testTwo:')
80 col!