Issue 10829455: Remove now unnecessary suppressions.

LGTM! Sorry for breaking you. https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/language.status File tests/language/language.status (left): https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/language.status#oldcode188 tests/language/language.status:188: # Final top-level field ...

8 years, 4 months ago (2012-08-21 15:55:17 UTC) #2

Anton Muhin

https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/language.status File tests/language/language.status (left): https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/language.status#oldcode188 tests/language/language.status:188: # Final top-level field declarations without initializer do not ...

8 years, 4 months ago (2012-08-21 18:27:30 UTC) #3

ahe

8 years, 4 months ago (2012-08-21 18:54:21 UTC) #4

https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/languag...
File tests/language/language.status (left):

https://chromiumcodereview.appspot.com/10829455/diff/1/tests/language/languag...
tests/language/language.status:188: # Final top-level field declarations without
initializer do not lead to errors in dart2js frontend.
On 2012/08/21 18:27:30, Anton Muhin wrote:
> On 2012/08/21 15:55:18, ahe wrote:
> > Hmm. I think the Dart VM is handling this error for you.
> 
> Before your change, F1/F3 were not even analyzed as they are never used. 
Hence
> dart2dart didn't emit it back for DartVM to complain about them.

I know. I just think it is unfortunate that dart2dart passes a test that it
should fail because the VM saves. Short-term, this is fine, but long term you
want to make sure that dart2dart doesn't spit out garbage. 

Hopefully, this should come for free as dart2js implements all semantic checks.

Expand Messages | Collapse Messages