Issue 10829446: Add HasSubclasses function to class hierarchy analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829446: Add HasSubclasses function to class hierarchy analysis. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add HasSubclasses function to class hierarchy analysis. Committed: https://code.google.com/p/dart/source/detail?r=11008

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -0 lines)			Patch
M	runtime/vm/class_table.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.cc	View	1 chunk	+12 lines, -0 lines	1 comment	Download
M	runtime/vm/class_table_test.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 4 months ago (2012-08-21 03:01:27 UTC) #3

https://chromiumcodereview.appspot.com/10829446/diff/1/runtime/vm/class_table.cc
File runtime/vm/class_table.cc (right):

https://chromiumcodereview.appspot.com/10829446/diff/1/runtime/vm/class_table...
runtime/vm/class_table.cc:100: bool ClassTable::HasSubclasses(intptr_t cid)
const {
This API has nothing to do with ClassTable, please remove it from here or
explain the tie in to the functionality of ClassTable which maps cids to
classes.

Expand Messages | Collapse Messages