Issue 10829431: Eliminate imported_into pointers in Library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829431: Eliminate imported_into pointers in Library (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate imported_into pointers in Library The imported_into pointers are no longer necessary with the new library scoping rules. Committed: https://code.google.com/p/dart/source/detail?r=10991

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -232 lines)			Patch
M	runtime/vm/object.h	View	3 chunks	+0 lines, -17 lines	0 comments	Download
M	runtime/vm/object.cc	View	8 chunks	+1 line, -211 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

8 years, 4 months ago (2012-08-20 17:53:36 UTC) #3

Thank you. The impact on isolate size is insignificant, about 1/4 KB:

Before:

$ dart --trace-isolates ~/tmp/d.dart
[+] Starting isolate:
	isolate:    d.dart/main-7112
Size of isolate snapshot = 779522
New space (0k of 32768k) Old space (1079k of 1280k) Code space (0k of 0k)


After:

$ dart --trace-isolates ~/tmp/d.dart 
[+] Starting isolate:
	isolate:    d.dart/main-7112
Size of isolate snapshot = 779215
New space (0k of 32768k) Old space (1079k of 1280k) Code space (0k of 0k)

Expand Messages | Collapse Messages