Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 10829416: Update language tests to new getter syntax. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Update language tests to new getter syntax. Committed: https://code.google.com/p/dart/source/detail?r=10943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -72 lines) Patch
M dart/tests/language/call_through_getter_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M dart/tests/language/call_through_null_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/cascade_precedence_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/compound_assignment_operator_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/language/const_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/language/field_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/getter_closure_execution_order_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/tests/language/getter_no_setter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/getter_setter_in_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/getters_setters2_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/tests/language/getters_setters_type2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/getters_setters_type3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/getters_setters_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/implicit_this_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/incr_op_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/instance_compound_assignment_operator_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/interface_inherit_field_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/language_dart2js.status View 1 chunk +56 lines, -1 line 0 comments Download
M dart/tests/language/map_literal2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/naming3_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/language/naming_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/optimized_setter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/parameter_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/prefix21_bad_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/prefix21_good_lib.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/property_field_override_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/setter0_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/setter1_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M dart/tests/language/setter_no_getter_call_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/side_effect_throw_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/skip_expression_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M dart/tests/language/static_implicit_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_closure_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/language/super_field_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_setter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/top_level_func_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/language/top_level_in_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/top_level_prefixed_declaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/type_variable_scope_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
8 years, 4 months ago (2012-08-20 09:20:21 UTC) #1
kasperl
LGTM as long as the tests still pass on the other platforms.
8 years, 4 months ago (2012-08-20 10:17:34 UTC) #2
ahe
8 years, 4 months ago (2012-08-20 11:29:52 UTC) #3
Thank you, Kasper. I know this is tedious :-)

On 2012/08/20 10:17:34, kasperl wrote:
> LGTM as long as the tests still pass on the other platforms.

This time, I tested the other platforms before sending out CL :-)

Cheers,
Peter

Powered by Google App Engine
This is Rietveld 408576698