Issue 10829332: - Split functionality of adding implicit constructors and checking

Issue 10829332: - Split functionality of adding implicit constructors and checking (Closed)

Created:
8 years, 4 months ago by Ivan Posva

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google), hausner, siva

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Split functionality of adding implicit constructors and checking for cycles into two functions. - Fix handling of closures in patch classes. Committed: https://code.google.com/p/dart/source/detail?r=10703

Patch Set 1 #

Total comments: 5

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -59 lines)			Patch
M	runtime/vm/dart_api_impl_test.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+16 lines, -12 lines	0 comments	Download
M	runtime/vm/parser.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+41 lines, -43 lines	5 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc#newcode3059 runtime/vm/parser.cc:3059: TokenPos(), Move this argument to the line above ...

8 years, 4 months ago (2012-08-15 07:21:24 UTC) #2

Ivan Posva

https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc#newcode3059 runtime/vm/parser.cc:3059: TokenPos(), On 2012/08/15 07:21:24, Mads Ager wrote: > Move ...

8 years, 4 months ago (2012-08-15 07:28:22 UTC) #3

hausner

Post-mortem LGTM with one question. https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (left): https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc#oldcode2951 runtime/vm/parser.cc:2951: ErrorMsg(classname_pos, "class '%s' is ...

8 years, 4 months ago (2012-08-15 16:39:27 UTC) #4

Ivan Posva

https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (left): https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc#oldcode2962 runtime/vm/parser.cc:2962: ErrorMsg(classname_pos, "class '%s' is already defined", Right here.

8 years, 4 months ago (2012-08-15 16:42:33 UTC) #5

hausner

8 years, 4 months ago (2012-08-15 17:01:09 UTC) #6

https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://chromiumcodereview.appspot.com/10829332/diff/1/runtime/vm/parser.cc#o...
runtime/vm/parser.cc:2962: ErrorMsg(classname_pos, "class '%s' is already
defined",
On 2012/08/15 16:42:33, Ivan Posva wrote:
> Right here.
Ah right, where it was before patch support. Thanks.

Expand Messages | Collapse Messages