Issue 10829313: Remove frog support from the annotated steps for dart2js and in browser testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829313: Remove frog support from the annotated steps for dart2js and in browser testing. (Closed)

Created:
8 years, 4 months ago by ricow1

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove frog support from the annotated steps for dart2js and in browser testing. Committed: https://code.google.com/p/dart/source/detail?r=10620

Patch Set 2 : #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -20 lines)			Patch
	M	utils/compiler/buildbot.py	View	1	9 chunks	+5 lines, -20 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Thanks, Rico! https://chromiumcodereview.appspot.com/10829313/diff/2001/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10829313/diff/2001/utils/compiler/buildbot.py#newcode35 utils/compiler/buildbot.py:35: - compiler: 'dart2js' or None when ...

8 years, 4 months ago (2012-08-14 07:05:44 UTC) #2

ricow1

8 years, 4 months ago (2012-08-14 07:41:13 UTC) #3

https://chromiumcodereview.appspot.com/10829313/diff/2001/utils/compiler/buil...
File utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10829313/diff/2001/utils/compiler/buil...
utils/compiler/buildbot.py:35: - compiler: 'dart2js' or None when the builder
has an
On 2012/08/14 07:05:44, kasperl wrote:
> Does the "- compiler" comment fit on one line now?

Yes

https://chromiumcodereview.appspot.com/10829313/diff/2001/utils/compiler/buil...
utils/compiler/buildbot.py:162: def TestCompiler(compiler, runtime, mode,
system, option, flags, is_buildbot):
On 2012/08/14 07:05:44, kasperl wrote:
> Could we get rid of the compiler parameter?
done

Expand Messages | Collapse Messages

Issue 10829313: Remove frog support from the annotated steps for dart2js and in browser testing. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages