Issue 10829036: Change the stack map search to require an exact match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829036: Change the stack map search to require an exact match. (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Change the stack map search to require an exact match. R=vegorov@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=10006

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)			Patch
M	runtime/vm/code_descriptors.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

It's error-prone to use a stack map for some other PC. Change the test that ...

8 years, 5 months ago (2012-07-26 14:20:23 UTC) #1

lgtm