Enhance 'Create Method' Quick Fix.

Enhance 'Create Method' Quick Fix.

1. Support for creating methods in classes, not just top-level functions.

2. Show suggestions for parameter names.

3. Show suggestions for parameter types.


R=messick@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10988

[messick, 2012-08-20 16:48:13]

lgtm

https://chromiumcodereview.appspot.com/10828389/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java
(right):

https://chromiumcodereview.appspot.com/10828389/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java:208:
private void addFix_createUnresolvedMethod(IProblemLocation location) throws
Exception {
Please justify throwing Exception in javadoc, or change to more specific
exception class(es).

[scheglov, 2012-08-20 17:02:01]

https://chromiumcodereview.appspot.com/10828389/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java
(right):

https://chromiumcodereview.appspot.com/10828389/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java:208:
private void addFix_createUnresolvedMethod(IProblemLocation location) throws
Exception {
On 2012/08/20 16:48:13, messick wrote:
> Please justify throwing Exception in javadoc, or change to more specific
> exception class(es).

Specifying general Exception class was deliberate decision.
We don't have here any way to recover from exception, so no reason to specify
them.
Also, this is just small UI feature, at worst case you will press Cmd+1 and it
will do nothing, fail silently. It will not show any scary dialog to user.