Issue 10828375: Remove meaningless test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828375: Remove meaningless test (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 4 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove meaningless test prefix_core_test has become meaningless with the new library and import scoping rules. It was also wrong since print is defined in library built-in, not core. Committed: https://code.google.com/p/dart/source/detail?r=10925

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -16 lines)			Patch
	M	tests/language/language.status	View		3 chunks	+1 line, -4 lines	1 comment	Download
	D	tests/language/prefix_core_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cshapiro

8 years, 4 months ago (2012-08-17 21:33:45 UTC) #2

lgtm

http://codereview.chromium.org/10828375/diff/4001/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/10828375/diff/4001/tests/language/language.sta...
tests/language/language.status:147: [ $browser ]
Any reason to keep this section now that it is empty?

Expand Messages | Collapse Messages