Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 10828355: Issue 4289. Test that arguments are bound to positional, optional and named parameters. (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 4289. Test that arguments are bound to positional, optional and named parameters. It just works, no real changes in TypeAnalyzer required. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10900

Patch Set 1 #

Patch Set 2 : Prepare for making optional parameter not named #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -9 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/VariableElement.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/VariableElementImplementation.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/DynamicTypeImplementation.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/FunctionType.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/FunctionTypeImplementation.java View 1 4 chunks +27 lines, -5 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 2 chunks +24 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/Types.java View 1 1 chunk +10 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/FunctionTypeTest.java View 1 1 chunk +2 lines, -1 line 1 comment Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +103 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
8 years, 4 months ago (2012-08-16 21:20:58 UTC) #1
Brian Wilkerson
LGTM. The question is, will it still work when we stop marking optional parameters as ...
8 years, 4 months ago (2012-08-16 21:27:48 UTC) #2
scheglov
On 2012/08/16 21:27:48, Brian Wilkerson wrote: > LGTM. > > The question is, will it ...
8 years, 4 months ago (2012-08-17 00:45:13 UTC) #3
Brian Wilkerson
8 years, 4 months ago (2012-08-17 14:07:34 UTC) #4
LGTM

https://chromiumcodereview.appspot.com/10828355/diff/5/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/type/FunctionTypeTest.java
(right):

https://chromiumcodereview.appspot.com/10828355/diff/5/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/FunctionTypeTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

Powered by Google App Engine
This is Rietveld 408576698