Issue 10828323: Temporary workaround to process default clauses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828323: Temporary workaround to process default clauses. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Temporary workaround to process default clauses. It's ugly and hacky, but all this stuff should go away with interfaces and default clauses. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10738

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	lib/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+12 lines, -0 lines	2 comments	Download
	M	tests/language/language.status	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10828323/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10828323/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode156 lib/compiler/implementation/dart_backend/backend.dart:156: TypeAnnotation evilCousine = new TypeAnnotation( What a hack!

8 years, 4 months ago (2012-08-15 14:52:22 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-15 15:11:34 UTC) #3

https://chromiumcodereview.appspot.com/10828323/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10828323/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:156: TypeAnnotation
evilCousine = new TypeAnnotation(
Yes, we can!

On 2012/08/15 14:52:22, Roman wrote:
> What a hack!

Expand Messages | Collapse Messages