Issue 10828320: Revert "Start adding TLS (SSL) sockets to dart:io."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828320: Revert "Start adding TLS (SSL) sockets to dart:io." (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Start adding TLS (SSL) sockets to dart:io." Revert "Add stub for TlsSocket to dart2js library." R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10700

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -999 lines)			Patch
M	lib/compiler/implementation/lib/io.dart	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	runtime/bin/bin.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/builtin_impl_sources.gypi	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/bin/dartutils.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	2 chunks	+12 lines, -27 lines	0 comments	Download
M	runtime/bin/file.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/bin/io_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	runtime/bin/tls_socket.h	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	runtime/bin/tls_socket.cc	View	1 chunk	+0 lines, -157 lines	0 comments	Download
D	runtime/bin/tls_socket.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	runtime/bin/tls_socket_android.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	runtime/bin/tls_socket_impl.dart	View	1 chunk	+0 lines, -310 lines	0 comments	Download
D	runtime/bin/tls_socket_linux.cc	View	1 chunk	+0 lines, -130 lines	0 comments	Download
D	runtime/bin/tls_socket_macos.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	runtime/bin/tls_socket_win.cc	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tests/standalone/io/tls_socket_test.dart	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  We will take a different approach to SSL.

Expand Messages | Collapse Messages