Issue 10828310: Move tests for things in /pkg into the right places for packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828310: Move tests for things in /pkg into the right places for packages (Closed)

Created:
8 years, 4 months ago by Alan Knight

Modified:
8 years, 4 months ago

Reviewers:
dgrove

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move tests for things in /pkg into the right places for packages Committed: https://code.google.com/p/dart/source/detail?r=10688

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1636 lines)			Patch
A	pkg/i18n/pubspec.yaml	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	pkg/i18n/tests/bidi_format_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	pkg/i18n/tests/bidi_utils_test.dart	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	pkg/i18n/tests/date_time_format_test.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	pkg/i18n/tests/date_time_format_test_data.dart	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	pkg/i18n/tests/intl_message_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/i18n/tests/intl_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/logging/pubspec.yaml	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A +	pkg/logging/tests/logging_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/pkg.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
D	tests/lib/i18n/bidi_format_test.dart	View		1 chunk	+0 lines, -211 lines	0 comments	Download
D	tests/lib/i18n/bidi_utils_test.dart	View		1 chunk	+0 lines, -346 lines	0 comments	Download
D	tests/lib/i18n/date_time_format_test.dart	View		1 chunk	+0 lines, -297 lines	0 comments	Download
D	tests/lib/i18n/date_time_format_test_data.dart	View		1 chunk	+0 lines, -334 lines	0 comments	Download
D	tests/lib/i18n/intl_message_test.dart	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	tests/lib/i18n/intl_test.dart	View		1 chunk	+0 lines, -15 lines	0 comments	Download
D	tests/lib/logging/logging_test.dart	View		1 chunk	+0 lines, -336 lines	0 comments	Download
M	tools/test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

We should probably move the tests for i18n and logging into /pkg too.

8 years, 4 months ago (2012-08-14 18:10:02 UTC) #1

Alan Knight

New version puts them in the tests sub-directory of each package.

8 years, 4 months ago (2012-08-14 22:23:05 UTC) #2

lgtm

Expand Messages | Collapse Messages