Issue 10828301: Test mini_parser.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828301: Test mini_parser.dart. (Closed)

Created:
8 years, 4 months ago by ahe

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Test mini_parser.dart. Committed: https://code.google.com/p/dart/source/detail?r=10627

Patch Set 1 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	dart/lib/compiler/implementation/tools/mini_parser.dart	View	2 chunks	+4 lines, -2 lines	1 comment	Download
M	dart/tests/compiler/dart2js/dart2js.status	View	1 chunk	+1 line, -1 line	0 comments	Download
A	dart/tests/compiler/dart2js/mini_parser_test.dart	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kasperl

8 years, 4 months ago (2012-08-14 08:30:03 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10828301/diff/2001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/tools/mini_parser.dart (right):

https://chromiumcodereview.appspot.com/10828301/diff/2001/dart/lib/compiler/i...
dart/lib/compiler/implementation/tools/mini_parser.dart:25: void main() {
toolMain(new Options().arguments); }
I'd prefer to put this on multiple lines. Break after {.

Expand Messages | Collapse Messages