Support for generic type variables and unresolved types added.

Support for generic type variables and unresolved types added.

Generic type variables are supported in really ugly way and
most probably should go into resolver eventually.

For types which cannot be resolved, unique name is generated for renaming.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=10490

[Roman, 2012-08-10 10:36:06]

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:160:
compiler.withCurrentElement(element, () {
Does it change anything?

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder.dart (right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder.dart:33: String
rename(ConflictingRenamer renamer) => renamer.generateUniqueName('unresolved');
>80

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:217: static
possibleTypeVariable(TypeAnnotation typeAnnotation) {
The name and signature of this method do not clearly tell me what it does. can
you please specify return type, and usually this kind of methods are prefixed
with "is"

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:225: //
print('visitTypeAnnotation(${node.toDebugString()}): currentElement:
$currentElement');
80 chars, debug stmt?

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:226: // Poor
man generic variables resolution.
Technically you don't resolve them, you skip type variables resolution, is this
correct?

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:262: if
(type !== compiler.types.dynamicType) {
We probably don't want to rename true "Dynamic" references to something
unresolved. Can you add this check here? I would expect some tests that use
Dynamic fail because of this change.

[Anton Muhin, 2012-08-10 10:49:19]

ptal

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:160:
compiler.withCurrentElement(element, () {
Yes, but it's tricky.

When type variables are resolved in typedefs/classes, it leads to compiler
warnings and if we don't set current element, those warnings hit an assert as
they expect the presence of top level element.  It was a feast to debug.

On 2012/08/10 10:36:06, Roman wrote:
> Does it change anything?

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder.dart (right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder.dart:33: String
rename(ConflictingRenamer renamer) => renamer.generateUniqueName('unresolved');
On 2012/08/10 10:36:06, Roman wrote:
> >80

Done.

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:217: static
possibleTypeVariable(TypeAnnotation typeAnnotation) {
бу-бу-бу

On 2012/08/10 10:36:06, Roman wrote:
> The name and signature of this method do not clearly tell me what it does. can
> you please specify return type, and usually this kind of methods are prefixed
> with "is"

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:225: //
print('visitTypeAnnotation(${node.toDebugString()}): currentElement:
$currentElement');
On 2012/08/10 10:36:06, Roman wrote:
> 80 chars, debug stmt?

Done.

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:226: // Poor
man generic variables resolution.
Yes.  I do resolve them, meaning I do understand that this type annotation maps
to type variable.  And in this case we don't have to rename it.

On 2012/08/10 10:36:06, Roman wrote:
> Technically you don't resolve them, you skip type variables resolution, is
this
> correct?

https://chromiumcodereview.appspot.com/10828250/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:262: if
(type !== compiler.types.dynamicType) {
On 2012/08/10 10:36:06, Roman wrote:
> We probably don't want to rename true "Dynamic" references to something
> unresolved. Can you add this check here? I would expect some tests that use
> Dynamic fail because of this change.

Done.

[Roman, 2012-08-10 11:20:18]

lgtm