Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 10828231: Add "android" as an expected OS target for platform test (Closed)

Created:
8 years, 4 months ago by jackpal
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add "android" as an expected OS target. Enables this test to pass when run on Android. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/standalone/io/platform_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jackpal
Patch 2 of 6 for building Dart VM for Android Another very small patch that ...
8 years, 4 months ago (2012-08-09 18:11:50 UTC) #1
Emily Fortuna
lgtm
8 years, 4 months ago (2012-08-09 20:04:45 UTC) #2
Ivan Posva
LGTM -ip
8 years, 4 months ago (2012-08-09 20:14:37 UTC) #3
Søren Gjesse
8 years, 4 months ago (2012-08-10 07:29:09 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698