Issue 10828182: Fix x64 performance regression, array allocation was always going via runtime. Improvements: Havlak…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828182: Fix x64 performance regression, array allocation was always going via runtime. Improvements: Havlak… (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix x64 performance regression, array allocation was always going via runtime. Improvements: Havlak 70%, DeltaBlue 20%, Meteor 20%. Committed: https://code.google.com/p/dart/source/detail?r=10319

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	runtime/vm/intrinsifier_x64.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

This synchronizes x64 with ia32. In a separate CL we must be smarter not to ...

8 years, 4 months ago (2012-08-06 22:14:49 UTC) #1

siva

lgtm https://chromiumcodereview.appspot.com/10828182/diff/1/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://chromiumcodereview.appspot.com/10828182/diff/1/runtime/vm/intrinsifier_x64.cc#newcode76 runtime/vm/intrinsifier_x64.cc:76: // RCX: new object end address. RCX is ...

8 years, 4 months ago (2012-08-06 22:47:17 UTC) #2