Chromium Code Reviews
DescriptionRevert "Make Directory::Current() work with unenhanced POSIX getcwd"
(Was committed by mistake.)
This reverts commit 75e15184afcd00e293a44ccba7dc1ead5387c382.
Merge remote-tracking branch 'refs/remotes/git-svn'
Revert "Make Directory::Current() work with unenhanced POSIX getcwd"
This reverts commit cab70428509870ae6ebf8de09d42991cc0318a07.
(Which was accidentally checked in before being reviewed.)
Make Directory::Current() work with unenhanced POSIX getcwd
POSIX says getcwd needs to be passed a pre-allocated
buffer, but many platforms provide an extended version
of getcwd that will allocate a buffer when called with
arguments (NULL, 0).
Display::Current() was depending upon this extended
behavior, which happens to work on Linux and Mac
platforms, but which doesn't work on other POSIX
platforms (such as Android.)
Fixed by using the preprocessor to choose between two
implementations of Display::Current, one of which depends
upon the extended semantics of getcwd, the other of which
only depends upon the standard semantics of getcwd.
BUG=
Committed: https://code.google.com/p/dart/source/detail?r=10316
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||