Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10828180: Revert "Make Directory::Current() work with unenhanced POSIX getcwd" (Closed)

Created:
8 years, 4 months ago by jackpal
Modified:
8 years, 4 months ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Make Directory::Current() work with unenhanced POSIX getcwd" (Was committed by mistake.) This reverts commit 75e15184afcd00e293a44ccba7dc1ead5387c382. Merge remote-tracking branch 'refs/remotes/git-svn' Revert "Make Directory::Current() work with unenhanced POSIX getcwd" This reverts commit cab70428509870ae6ebf8de09d42991cc0318a07. (Which was accidentally checked in before being reviewed.) Make Directory::Current() work with unenhanced POSIX getcwd POSIX says getcwd needs to be passed a pre-allocated buffer, but many platforms provide an extended version of getcwd that will allocate a buffer when called with arguments (NULL, 0). Display::Current() was depending upon this extended behavior, which happens to work on Linux and Mac platforms, but which doesn't work on other POSIX platforms (such as Android.) Fixed by using the preprocessor to choose between two implementations of Display::Current, one of which depends upon the extended semantics of getcwd, the other of which only depends upon the standard semantics of getcwd. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M runtime/bin/directory_posix.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jackpal
Reverting an accidentally-checked-in change. (Asking iposva and asiva to review because they both noticed.)
8 years, 4 months ago (2012-08-06 22:22:05 UTC) #1
Ivan Posva
8 years, 4 months ago (2012-08-06 22:31:49 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698