Issue 10828076: Support signed constants.

Issue 10828076: Support signed constants. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support signed constants. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10039

Patch Set 2 : No with doubles #

Patch Set 3 : Ready for review #

Total comments: 4

Patch Set 5 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
M	lib/compiler/implementation/tree/unparser.dart	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/unparser_test.dart	View	1 2 3	2 chunks	+14 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10828076/diff/5001/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10828076/diff/5001/lib/compiler/implementation/tree/unparser.dart#newcode146 lib/compiler/implementation/tree/unparser.dart:146: if (node.token.kind == PLUS_TOKEN) add(node.token.next.value); please add a ...

8 years, 4 months ago (2012-07-31 07:52:12 UTC) #3

Anton Muhin

8 years, 4 months ago (2012-07-31 08:01:16 UTC) #4

https://chromiumcodereview.appspot.com/10828076/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10828076/diff/5001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:146: if (node.token.kind ==
PLUS_TOKEN) add(node.token.next.value);
On 2012/07/31 07:52:12, Roman wrote:
> please add a comment about how things like "-42" are represented as send

Done.

https://chromiumcodereview.appspot.com/10828076/diff/5001/tests/compiler/dart...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10828076/diff/5001/tests/compiler/dart...
tests/compiler/dart2js/unparser_test.dart:78: testSignedConstants() {
On 2012/07/31 07:52:12, Roman wrote:
> what about +inf, -inf, +0.0, -0.0 ?

There is no inf, zero tests are added

Expand Messages | Collapse Messages