Support proxying of objects between JS and Dart.

Support proxying of objects between JS and Dart.

Committed: https://code.google.com/p/dart/source/detail?r=11182

[Emily Fortuna, 2012-08-21 23:39:56]

mainly just a few style notes

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode50
client/dart.js:50: // TODO: Fix leaks, particularly in dart2js case.
TODO(vsm):

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode61
client/dart.js:61: // TODO: Cache refs for each obj.
add username to TODO :-)

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode63
client/dart.js:63: this.map[ref] = obj;
Is this for improved debugging experience (could be useful)? If not, why not
just use an array, where nextId is the index number into the array?

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode76
client/dart.js:76: }
move this up to the previous line?
http://www.corp.google.com/eng/doc/javascriptguide.xml?showone=Method_definit...

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode83
client/dart.js:83: }
probably can move this } up onto the previous line

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode93
client/dart.js:93: // TODO: Should we capture this automatically?
TODO(vsm):

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode103
client/dart.js:103: JSRefTable.prototype = new RefTable('js-ref');
add an extra whitespace line above

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode150
client/dart.js:150: // TODO(vsm): Is the above portable and what we want?
remove tabs here

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode152
client/dart.js:152: return [ 'objref', 'nativejs', jsRefTable.makeRef(message)
];
I thought all objects in JS could be examined as maps (?)

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
File lib/html/src/Isolates.dart (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:66: _nextId = 0,
lines 66 and 67 could be up on line 65, right?

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:122: get _dartProxyRegistry() {
use new getter syntax:
get _dartProxyRegistry {
  ...
}

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:123: if (__dartProxyRegistry === null)
__dartProxyRegistry = new _DartProxyRegistry();
80 char

https://chromiumcodereview.appspot.com/10827462/diff/1/tests/html/js_interop_...
File tests/html/js_interop_obj_passing_test.dart (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/tests/html/js_interop_...
tests/html/js_interop_obj_passing_test.dart:80: 
superfluous whitespace?

[dgrove, 2012-08-21 23:43:27]

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode171
client/dart.js:171: function deserializeHelper(x) {
better name than "x"?

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode188
client/dart.js:188: function deserializeMap(x) {
ditto

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode226
client/dart.js:226: function deserializeFunction(x) {
ditto

[vsm, 2012-08-22 00:04:28]

thanks, PTAL.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode50
client/dart.js:50: // TODO: Fix leaks, particularly in dart2js case.
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> TODO(vsm):

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode61
client/dart.js:61: // TODO: Cache refs for each obj.
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> add username to TODO :-)

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode63
client/dart.js:63: this.map[ref] = obj;
Primarily debugging ease.  Makes it easier to tell where the ref came from than
just a number.

On 2012/08/21 23:39:56, Emily Fortuna wrote:
> Is this for improved debugging experience (could be useful)? If not, why not
> just use an array, where nextId is the index number into the array?

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode76
client/dart.js:76: }
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> move this up to the previous line?
>
http://www.corp.google.com/eng/doc/javascriptguide.xml?showone=Method_definit...

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode83
client/dart.js:83: }
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> probably can move this } up onto the previous line

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode93
client/dart.js:93: // TODO: Should we capture this automatically?
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> TODO(vsm):

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode103
client/dart.js:103: JSRefTable.prototype = new RefTable('js-ref');
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> add an extra whitespace line above

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode150
client/dart.js:150: // TODO(vsm): Is the above portable and what we want?
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> remove tabs here

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode152
client/dart.js:152: return [ 'objref', 'nativejs', jsRefTable.makeRef(message)
];
Right.  The proto check in the preceding if is trying to differentiate between
maps created like "{'a': 1}" and ones that look more like objects.  Still not
sure this is the best way to go about this.

On 2012/08/21 23:39:56, Emily Fortuna wrote:
> I thought all objects in JS could be examined as maps (?)

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode171
client/dart.js:171: function deserializeHelper(x) {
On 2012/08/21 23:43:27, dgrove wrote:
> better name than "x"?

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode188
client/dart.js:188: function deserializeMap(x) {
On 2012/08/21 23:43:27, dgrove wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/client/dart.js#newcode226
client/dart.js:226: function deserializeFunction(x) {
On 2012/08/21 23:43:27, dgrove wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
File lib/html/src/Isolates.dart (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:66: _nextId = 0,
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> lines 66 and 67 could be up on line 65, right?

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:122: get _dartProxyRegistry() {
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> use new getter syntax:
> get _dartProxyRegistry {
>   ...
> }

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/lib/html/src/Isolates....
lib/html/src/Isolates.dart:123: if (__dartProxyRegistry === null)
__dartProxyRegistry = new _DartProxyRegistry();
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> 80 char

Done.

https://chromiumcodereview.appspot.com/10827462/diff/1/tests/html/js_interop_...
File tests/html/js_interop_obj_passing_test.dart (right):

https://chromiumcodereview.appspot.com/10827462/diff/1/tests/html/js_interop_...
tests/html/js_interop_obj_passing_test.dart:80: 
On 2012/08/21 23:39:56, Emily Fortuna wrote:
> superfluous whitespace?

Done.

[Emily Fortuna, 2012-08-22 00:13:53]

lgtm!

FWIW, we seem to be in some strange in-between period on the getter syntax. I
sent in that CL yesterday because dromaeo wasn't compiling with dart2js with the
old syntax, but there are many places in our codebase where we're still using
the old version. But this way, you'll be ready when the stop supporting the over
way.