Issue 10827450: Move class hierarchy analysis to its own source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827450: Move class hierarchy analysis to its own source. (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move class hierarchy analysis to its own source. Committed: https://code.google.com/p/dart/source/detail?r=11097

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -242 lines)			Patch
A	runtime/vm/cha.h	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
A	runtime/vm/cha.cc	View	1 2	1 chunk	+106 lines, -0 lines	0 comments	Download
A	runtime/vm/cha_test.cc	View	1 2	1 chunk	+130 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.h	View	1 2 3	2 chunks	+0 lines, -23 lines	0 comments	Download
M	runtime/vm/class_table.cc	View	1 2 3	1 chunk	+0 lines, -87 lines	0 comments	Download
D	runtime/vm/class_table_test.cc	View	1 2 3	1 chunk	+0 lines, -131 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10827450/diff/1/runtime/vm/cha.h File runtime/vm/cha.h (right): https://chromiumcodereview.appspot.com/10827450/diff/1/runtime/vm/cha.h#newcode42 runtime/vm/cha.h:42: const ClassTable& class_table_; DISALLOW_COPY ...

8 years, 4 months ago (2012-08-21 18:46:24 UTC) #2

regis

PTAL CHA is now AllStatic, as requested by Ivan. -- Regis https://chromiumcodereview.appspot.com/10827450/diff/1/runtime/vm/cha.h File runtime/vm/cha.h (right): ...

8 years, 4 months ago (2012-08-21 20:09:34 UTC) #3

regis

8 years, 4 months ago (2012-08-21 20:50:17 UTC) #5

While waiting for the build to turn green before submitting, changed
HasSuclasses to return true for Object class.

-- Regis

Expand Messages | Collapse Messages

Issue 10827450: Move class hierarchy analysis to its own source. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages