Issue 10827448: Support sourceing files in patches.

Issue 10827448: Support sourceing files in patches. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin, Mads Ager (google)

CC:
reviews_dartlang.org, ahe, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support sourceing files in patches. The path given is relative to the patch, not the library. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11082

Patch Set 2 : Remove unneded code. #

Total comments: 1

Patch Set 3 : Refactor. #

Total comments: 6

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
	M	lib/compiler/implementation/patch_parser.dart	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
	M	lib/compiler/implementation/scanner/scanner_task.dart	View	1 2	2 chunks	+11 lines, -4 lines	6 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Any tests? https://chromiumcodereview.appspot.com/10827448/diff/2001/lib/compiler/implementation/patch_parser.dart File lib/compiler/implementation/patch_parser.dart (right): https://chromiumcodereview.appspot.com/10827448/diff/2001/lib/compiler/implementation/patch_parser.dart#newcode42 lib/compiler/implementation/patch_parser.dart:42: Script script = compiler.readScript(resolved, tag); that looks ...

8 years, 4 months ago (2012-08-21 18:09:33 UTC) #2

Anders Johnsen

PTAL, We don't have a very good test environment patches yet. I'll see if I ...

8 years, 4 months ago (2012-08-21 18:27:57 UTC) #3

Mads Ager (google)

LGTM, but I would like different naming. https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implementation/scanner/scanner_task.dart File lib/compiler/implementation/scanner/scanner_task.dart (right): https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implementation/scanner/scanner_task.dart#newcode88 lib/compiler/implementation/scanner/scanner_task.dart:88: * Source ...

8 years, 4 months ago (2012-08-22 07:40:03 UTC) #5

Anders Johnsen

8 years, 4 months ago (2012-08-22 13:02:27 UTC) #6

https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/scanner/scanner_task.dart (right):

https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implem...
lib/compiler/implementation/scanner/scanner_task.dart:88: * Source a tag in the
scope of [library]. The [path] given is used as is,
On 2012/08/22 07:40:03, Mads Ager wrote:
> Handle a source tag in the scope of [library]?
> 
> At least in my mind you source a file/script with a source tag, but you don't
> source a tag?

Done.

https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implem...
lib/compiler/implementation/scanner/scanner_task.dart:89: * any resolve should
be done beforehand.
On 2012/08/22 07:40:03, Mads Ager wrote:
> any resolution

Done.

https://chromiumcodereview.appspot.com/10827448/diff/6001/lib/compiler/implem...
lib/compiler/implementation/scanner/scanner_task.dart:91: void
sourceTagInLibrary(ScriptTag tag, Uri path, LibraryElement library) {
On 2012/08/22 07:40:03, Mads Ager wrote:
> Rename. sourceScript? importSourceFromTag (to match importLibraryFromTag)?

Done.

Expand Messages | Collapse Messages