Issue 10827434: - Pass the correct version of handle reference to Class::NewNativeWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827434: - Pass the correct version of handle reference to Class::NewNativeWrapper. (Closed)

Created:
8 years, 4 months ago by Ivan Posva

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Pass the correct version of handle reference to Class::NewNativeWrapper. Committed: https://code.google.com/p/dart/source/detail?r=11012

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 4 months ago (2012-08-21 09:27:33 UTC) #2

On 2012/08/21 02:49:27, Ivan Posva wrote:
> TBR
> 
> -Ivan

LGTM.  Could you explain the principle of using const references for VM handles,
rather than pointers or references?  The const means that we can't change the
handle to point to a different object, right?

Expand Messages | Collapse Messages