Do not create placeholders for elements that won't be later renamed.

Do not create placeholders for elements that won't be later renamed.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=11023

[Roman, 2012-08-21 07:44:58]

lgtm

https://chromiumcodereview.appspot.com/10827424/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10827424/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:263: if
(element === entryFunction) return;
This is not the problem of your CL, but we should actually have an element for
MAIN, because otherwise another library may define it's own main element that
won't be renamed:

#library('lib.dart');
void main() {}

...
#import('lib.dart', prefix:'lib');
main() {
  lib.main();
}

To fix this, we should check MAIN element in rename and don't rename it, but
instead just add it to used top level identifiers. OR we can just add 'main' to
used top level identifiers in renamer at the beginning.

[Anton Muhin, 2012-08-21 09:16:54]

https://chromiumcodereview.appspot.com/10827424/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10827424/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:263: if
(element === entryFunction) return;
Good point, I'll fix it.

On 2012/08/21 07:44:58, Roman wrote:
> This is not the problem of your CL, but we should actually have an element for
> MAIN, because otherwise another library may define it's own main element that
> won't be renamed:
> 
> #library('lib.dart');
> void main() {}
> 
> ...
> #import('lib.dart', prefix:'lib');
> main() {
>   lib.main();
> }
> 
> To fix this, we should check MAIN element in rename and don't rename it, but
> instead just add it to used top level identifiers. OR we can just add 'main'
to
> used top level identifiers in renamer at the beginning.