Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 10827399: Add an optional argument to HTMLCanvasElement.toDataURL. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add an optional argument to HTMLCanvasElement.toDataURL. That brings us closer to the spec and actual usage. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=10896

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M lib/dom/dart2js/dom_dart2js.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/dom/dom.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/idl/dart/dart.idl View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-08-17 11:41:04 UTC) #1
vsm
8 years, 4 months ago (2012-08-17 13:18:02 UTC) #2
lgtm - thanks!

Can you also rerun fremontcutbuilder.py && dartdomgenerator.py before landing?

Powered by Google App Engine
This is Rietveld 408576698