Issue 10827397: String+ does not exist anymore. Fix issue #3857.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827397: String+ does not exist anymore. Fix issue #3857. (Closed)

Created:
8 years, 4 months ago by ngeoffray

Modified:
8 years, 4 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

String+ does not exist anymore. Fix issue #3710. Committed: https://code.google.com/p/dart/source/detail?r=10886

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js_extra/this_phi_elimination_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10827397/diff/2001/tests/compiler/dart2js_extra/this_phi_elimination_test.dart File tests/compiler/dart2js_extra/this_phi_elimination_test.dart (right): https://chromiumcodereview.appspot.com/10827397/diff/2001/tests/compiler/dart2js_extra/this_phi_elimination_test.dart#newcode18 tests/compiler/dart2js_extra/this_phi_elimination_test.dart:18: bool caughtException = false; Use Expect.throws(() => new ...

8 years, 4 months ago (2012-08-17 11:30:53 UTC) #2

ngeoffray

8 years, 4 months ago (2012-08-17 11:48:04 UTC) #3

Thanks Kasper

https://chromiumcodereview.appspot.com/10827397/diff/2001/tests/compiler/dart...
File tests/compiler/dart2js_extra/this_phi_elimination_test.dart (right):

https://chromiumcodereview.appspot.com/10827397/diff/2001/tests/compiler/dart...
tests/compiler/dart2js_extra/this_phi_elimination_test.dart:18: bool
caughtException = false;
On 2012/08/17 11:30:53, kasperl wrote:
> Use Expect.throws(() => new A().foo(""), (e) => e is NoSuchMethodException)?

Good point. Done.

Expand Messages | Collapse Messages

Issue 10827397: String+ does not exist anymore. Fix issue #3857. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages