Issue 10827387: Reenable elimination of strict equals when right side is true.

Issue 10827387: Reenable elimination of strict equals when right side is true. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reenable elimination of strict equals when right side is true. Reenable some Smi check eliminations. Soon Florian will factor out class checks into own instruction where the elimination will be moved. Implement more ResultCid()-s, removed TODO to make it asbtract because almost all computations return kDynamicCid. Committed: https://code.google.com/p/dart/source/detail?r=10865

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -50 lines)			Patch
M	runtime/vm/flow_graph.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	14 chunks	+13 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	4 chunks	+67 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	4 chunks	+5 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	4 chunks	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with one formatting detail and one question. https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermediate_language.cc#newcode953 runtime/vm/intermediate_language.cc:953: return ...

8 years, 4 months ago (2012-08-16 21:43:52 UTC) #2

srdjan

8 years, 4 months ago (2012-08-16 22:11:05 UTC) #3

https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermed...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermed...
runtime/vm/intermediate_language.cc:953: return Type::DoubleInterface();
On 2012/08/16 21:43:52, regis wrote:
> Why?

Adding comment:
Implemented only for doubles.

Added assert in EmitNatives so that we keep them in sync.

https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10827387/diff/6001/runtime/vm/intermed...
runtime/vm/intermediate_language.h:305: // Assert if BindsToConstant() is false,
otherwise returns constant.
On 2012/08/16 21:43:52, regis wrote:
> Missing empty line. Or group with BindsToConstant() above and not with
> BindsToConstantNull().

Added empty line.

Expand Messages | Collapse Messages