Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 10827367: 1. Fix an issue with VM class names being null (this is exposed when doing a heap profile) (Closed)

Created:
8 years, 4 months ago by siva
Modified:
8 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

1. Fix an issue with VM class names being null (this is exposed when doing a heap profile) 2. Move more VM class names as singletons to the VM isolate. Committed: https://code.google.com/p/dart/source/detail?r=10847

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -49 lines) Patch
M vm/object.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M vm/object.cc View 1 6 chunks +90 lines, -43 lines 0 comments Download
M vm/symbols.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
M vm/symbols.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 4 months ago (2012-08-16 17:19:34 UTC) #1
hausner
lgtm
8 years, 4 months ago (2012-08-16 17:26:35 UTC) #2
siva
8 years, 4 months ago (2012-08-16 17:35:55 UTC) #3
Thanks.

Powered by Google App Engine
This is Rietveld 408576698