Issue 10827327: Add GDB JIT support back into Android build.

Issue 10827327: Add GDB JIT support back into Android build. (Closed)

Created:
8 years, 4 months ago by jackpal

Modified:
8 years, 4 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add GDB JIT support back into Android build. Based on Linux version. Committed: https://code.google.com/p/dart/source/detail?r=10697

Patch Set 2 : Move common ELF generation code into a shared header file. #

Total comments: 5

Patch Set 3 : Remove extra blank lines as requested by reviewer. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -560 lines)			Patch
M	runtime/vm/debuginfo_android.cc	View	1 2	2 chunks	+28 lines, -7 lines	0 comments	Download
M	runtime/vm/debuginfo_linux.cc	View	1 2	1 chunk	+1 line, -488 lines	0 comments	Download
A +	runtime/vm/elfgen.h	View	1 2	2 chunks	+4 lines, -65 lines	0 comments	Download
M	runtime/vm/gdbjit_android.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/gdbjit_linux.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cshapiro

https://chromiumcodereview.appspot.com/10827327/diff/1/runtime/vm/debuginfo_android.cc File runtime/vm/debuginfo_android.cc (right): https://chromiumcodereview.appspot.com/10827327/diff/1/runtime/vm/debuginfo_android.cc#newcode14 runtime/vm/debuginfo_android.cc:14: // ----------------------------------------------------------------------------- Can you move this into an elfgen.h ...

8 years, 4 months ago (2012-08-14 22:18:25 UTC) #2

jackpal

http://codereview.chromium.org/10827327/diff/1/runtime/vm/debuginfo_android.cc File runtime/vm/debuginfo_android.cc (right): http://codereview.chromium.org/10827327/diff/1/runtime/vm/debuginfo_android.cc#newcode14 runtime/vm/debuginfo_android.cc:14: // ----------------------------------------------------------------------------- On 2012/08/14 22:18:26, cshapiro wrote: > Can ...

8 years, 4 months ago (2012-08-15 01:29:48 UTC) #3

cshapiro

8 years, 4 months ago (2012-08-15 01:45:07 UTC) #4

just a few minor whitespace tweaks, please clean up before submitting

otherwise, lgtm

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_androi...
File runtime/vm/debuginfo_android.cc (right):

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_androi...
runtime/vm/debuginfo_android.cc:5: 
Remove this.

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_androi...
runtime/vm/debuginfo_android.cc:73: 
Remove this.

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_linux.cc
File runtime/vm/debuginfo_linux.cc (right):

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_linux....
runtime/vm/debuginfo_linux.cc:5: 
Remove this.

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/debuginfo_linux....
runtime/vm/debuginfo_linux.cc:73: 
Remove this.

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/elfgen.h
File runtime/vm/elfgen.h (right):

http://codereview.chromium.org/10827327/diff/4001/runtime/vm/elfgen.h#newcode497
runtime/vm/elfgen.h:497: 
Remove line 497

Expand Messages | Collapse Messages