Issue 10827286: Fix for issue 4429 - remove #resource directive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827286: Fix for issue 4429 - remove #resource directive (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson

Modified:
8 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 4429 - remove #resource directive Committed: https://code.google.com/p/dart/source/detail?r=10530

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+476 lines, -663 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/ASTVisitor.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartPlainVisitor.java	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	compiler/java/com/google/dart/compiler/ast/DartResourceDirective.java	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/LibraryUnit.java	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	4 chunks	+5 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/DartASTValidator.java	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/Directives.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/Directives2.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java	View	2 chunks	+0 lines, -25 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyDescriptorHelper.java	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyGetter.java	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertyLocator.java	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/PropertySetter.java	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/visitor/WrappedDartVisitorAdaptor.java	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/ASTRewriteAnalyzer.java	View	25 chunks	+216 lines, -205 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/CodeFormatterVisitor.java	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java	View	18 chunks	+61 lines, -53 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java	View	21 chunks	+49 lines, -65 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartModelManager.java	View	32 chunks	+103 lines, -98 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java	View	16 chunks	+34 lines, -57 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/samples/SamplesTest.java	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages