Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 10827275: Add flag --disassemble-optimized to selectively disassemble function with optimized code. (Closed)

Created:
8 years, 4 months ago by Florian Schneider
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add flag --disassemble-optimized to selectively disassemble function with optimized code. Committed: https://code.google.com/p/dart/source/detail?r=10489

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -81 lines) Patch
M vm/compiler.cc View 3 chunks +91 lines, -81 lines 4 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
8 years, 4 months ago (2012-08-10 10:21:46 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc File vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc#newcode343 vm/compiler.cc:343: add empty line here
8 years, 4 months ago (2012-08-10 10:41:36 UTC) #2
srdjan
DBC https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc File vm/compiler.cc (right): https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc#newcode393 vm/compiler.cc:393: DisassembleCode(function, true); I do not understand why you ...
8 years, 4 months ago (2012-08-10 14:00:10 UTC) #3
Florian Schneider
8 years, 4 months ago (2012-08-13 08:26:01 UTC) #4
https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc
File vm/compiler.cc (right):

https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc#newcode343
vm/compiler.cc:343: 
On 2012/08/10 10:41:36, Vyacheslav Egorov (Google) wrote:
> add empty line here

Done.

https://chromiumcodereview.appspot.com/10827275/diff/1/vm/compiler.cc#newcode393
vm/compiler.cc:393: DisassembleCode(function, true);
On 2012/08/10 14:00:10, srdjan wrote:
> I do not understand why you call DisassembleCode twice.
> Also, you may want to handle case with --disassemble --disassemble_optimized
so
> that you do not disassemble more than once.

This is just to see the non-optimized code together with the optimized code for
all optimized functions. Yes, if --disassemble is on, we don't want to
disassembe twice. I'll fix that.

Powered by Google App Engine
This is Rietveld 408576698