Implement new catch syntax in vm compiler

Implement new catch syntax in vm compiler

- Support for new on T catch (e) syntax
- warning (default:off) when old catch clause syntax is found
- convert one language test to used new catch syntax
Committed: https://code.google.com/p/dart/source/detail?r=10456

[siva, 2012-08-09 19:59:29]

lgtm

http://codereview.chromium.org/10827240/diff/2001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10827240/diff/2001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5622: }
The processing of the stacktrace part seems identical in both cases, here and
the code above. You could possibly abstract that out into a helper function.

[hausner, 2012-08-09 20:14:49]

Thanks for the review.

http://codereview.chromium.org/10827240/diff/2001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10827240/diff/2001/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:5622: }
On 2012/08/09 19:59:29, asiva wrote:
> The processing of the stacktrace part seems identical in both cases, here and
> the code above. You could possibly abstract that out into a helper function.

True, but when I'll eliminate the code for the old syntax, I will restructure
this so that the catch(e,t) part is handled only once. In the meantime, I think
a bit of code duplication does not do any harm.