Add samples gyp target to Dart project, that builds samples/sample_extension.

Add samples gyp target to Dart project, that builds samples/sample_extension.


BUG=dart:3008
Committed: https://code.google.com/p/dart/source/detail?r=11131

[Bill Hesse, 2012-08-07 10:24:55]

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
File samples/sample_extension/sample_extension.gypi (right):

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
samples/sample_extension/sample_extension.gypi:14: '../../runtime/include',
I checked, and this needs to be ../../runtime, and the line above needs to be
../runtime.  What is going on?

[ahe, 2012-08-07 11:42:31]

https://chromiumcodereview.appspot.com/10827197/diff/2001/dart.gyp
File dart.gyp (right):

https://chromiumcodereview.appspot.com/10827197/diff/2001/dart.gyp#newcode26
dart.gyp:26: 'target_name': 'samples',
I think it would be nice if you added this to the end of the file.

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
File samples/sample_extension/sample_extension.gypi (right):

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
samples/sample_extension/sample_extension.gypi:14: '../../runtime/include',
On 2012/08/07 10:24:55, Bill Hesse wrote:
> I checked, and this needs to be ../../runtime, and the line above needs to be
> ../runtime.  What is going on?

The problem is that you didn't put the gyp file in the same directory as the
gypi file. Please don't do that. It is impossible to understand.

[Bill Hesse, 2012-08-07 12:23:18]

Changed, so that the samples target in dart.gyp now directly gives
sample_extension as a dependency, and sample_extension is just in
samples/sample_extension/sample_extension.gyp.

https://chromiumcodereview.appspot.com/10827197/diff/2001/dart.gyp
File dart.gyp (right):

https://chromiumcodereview.appspot.com/10827197/diff/2001/dart.gyp#newcode26
dart.gyp:26: 'target_name': 'samples',
On 2012/08/07 11:42:31, ahe wrote:
> I think it would be nice if you added this to the end of the file.

Done.

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
File samples/sample_extension/sample_extension.gypi (right):

https://chromiumcodereview.appspot.com/10827197/diff/2001/samples/sample_exte...
samples/sample_extension/sample_extension.gypi:14: '../../runtime/include',
Fixed.  This is now a gyp file.

On 2012/08/07 11:42:31, ahe wrote:
> On 2012/08/07 10:24:55, Bill Hesse wrote:
> > I checked, and this needs to be ../../runtime, and the line above needs to
be
> > ../runtime.  What is going on?
> 
> The problem is that you didn't put the gyp file in the same directory as the
> gypi file. Please don't do that. It is impossible to understand.

[Bill Hesse, 2012-08-17 10:58:15]

Please take a look.

[ahe, 2012-08-21 14:42:33]

LGTM!