Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 10827165: Reverted a couple of earlier cleanups to the unittest framework. They introduced issues with cases … (Closed)

Created:
8 years, 4 months ago by gram
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reverted a couple of earlier cleanups to the unittest framework. They introduced issues with cases where we wrap non-unittest code in browser test wrappers, and this wrapped code throws exceptions before the deferred call to runTests starts. Committed: https://code.google.com/p/dart/source/detail?r=10267

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M lib/unittest/interactive_html_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/unittest/unittest.dart View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
8 years, 4 months ago (2012-08-03 22:32:43 UTC) #1
gram
8 years, 4 months ago (2012-08-03 23:03:03 UTC) #2
Siggi Cherem (dart-lang)
8 years, 4 months ago (2012-08-03 23:04:11 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698