Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10826301: Change clobbering to use the new script inside the dart tools directory. (Closed)

Created:
8 years, 4 months ago by ricow1
Modified:
8 years, 4 months ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change clobbering to use the new script inside the dart tools directory. This is the first step in unifying our clobbering functionality, I will change the vm and dartc bots to use this in another cl (the current scripts reside in another repository). Also, I will do another follow up for browser bot clobbering later, including changing the current wrong clobber for windows 7 bots (which uses the old naming scheme for output directories) Committed: https://code.google.com/p/dart/source/detail?r=10644

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M utils/compiler/buildbot.py View 3 chunks +19 lines, -17 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
ricow1
8 years, 4 months ago (2012-08-14 11:17:25 UTC) #1
ricow1
Adding mads, peter is gone
8 years, 4 months ago (2012-08-14 13:13:37 UTC) #2
Mads Ager (google)
LGTM
8 years, 4 months ago (2012-08-14 13:18:00 UTC) #3
ahe
8 years, 4 months ago (2012-08-14 17:57:20 UTC) #4
LGTM

Thank you for cleaning this up, Rico!

Cheers,
Peter

https://chromiumcodereview.appspot.com/10826301/diff/1/utils/compiler/buildbo...
File utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10826301/diff/1/utils/compiler/buildbo...
utils/compiler/buildbot.py:308: if os.environ.get(BUILDER_CLOBBER) == "1":
return os.environ.get(BUILDER_CLOBBER) == "1"

Powered by Google App Engine
This is Rietveld 408576698