Add _android files for building DartVM on Android

Add _android files for building DartVM on Android

Split directory_posix -> directory_(android|linux|macos)
  This allows us to cleanly make Android-specific changes to
  directory_android.cc

Copy all _linux files to _android files and edit as needed to account
for the differences between Linux and Android:

 + getcwd(0, NULL) doesn't work on Android, have to emulate
 + Android doesn't have a '/tmp' directory, have to emulate
 + Android doesn't provide mkdtemp(), have to emulate.
 + Small differences in the available system include files.
 + Use pthread_cond_timedwait_monotonic instead of
   pthread_condattr_setclock

Committed: https://code.google.com/p/dart/source/detail?r=10613

[jackpal, 2012-08-09 18:28:34]

Patch 5 of 6 for building Dart VM for Android

This patch creates all the _android.(cc|h) files.

[Emily Fortuna, 2012-08-09 20:06:01]

this seems fine to me, but I'm going to let someone more familiar with the VM
actually aprove this.

[siva, 2012-08-10 00:13:47]

LGTM.

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/bin/directory_...
File runtime/bin/directory_android.cc (right):

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/bin/directory_...
runtime/bin/directory_android.cc:398: // Android doesn't currently provide
mkdtemp
end comment with a "."

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/bin/socket_and...
File runtime/bin/socket_android.cc (right):

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/bin/socket_and...
runtime/bin/socket_android.cc:127: int len = sizeof(errorNumber);
why not declare this as socklen_t
i.e socklen_t len = ....;
or have an assertion:
sizeof(socklen_t) == sizeof(int);

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/debuginfo_a...
File runtime/vm/debuginfo_android.cc (right):

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/debuginfo_a...
runtime/vm/debuginfo_android.cc:3: // BSD-style license that can be found in the
LICENSE file.
do you need the files gdbjit_android.h, gdbjit_android.cc and
debuginfo_android.cc?

Does gdb on Android support debugging of dynamically generated code (JIT
Compilation Interface)?

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/gdbjit_andr...
File runtime/vm/gdbjit_android.cc (right):

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/gdbjit_andr...
runtime/vm/gdbjit_android.cc:3: // BSD-style license that can be found in the
LICENSE file.
Ditto comment.

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/gdbjit_andr...
File runtime/vm/gdbjit_android.h (right):

https://chromiumcodereview.appspot.com/10826233/diff/1/runtime/vm/gdbjit_andr...
runtime/vm/gdbjit_android.h:3: // BSD-style license that can be found in the
LICENSE file.
Ditto comment.

[Søren Gjesse, 2012-08-10 07:28:28]

lgtm

http://codereview.chromium.org/10826233/diff/1/runtime/bin/directory_android.cc
File runtime/bin/directory_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/bin/directory_android....
runtime/bin/directory_android.cc:399: static char* Mkdtemp(char* path_template)
{
How about calling it MakeTempDirectory so that it is clear at the call site that
this is not a system call?

http://codereview.chromium.org/10826233/diff/1/runtime/vm/virtual_memory_andr...
File runtime/vm/virtual_memory_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/vm/virtual_memory_andr...
runtime/vm/virtual_memory_android.cc:29: // TODO(4408): use ashmem instead of
anonymous memory
End comment with .

[jackpal, 2012-08-13 22:59:42]

http://codereview.chromium.org/10826233/diff/1/runtime/bin/directory_android.cc
File runtime/bin/directory_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/bin/directory_android....
runtime/bin/directory_android.cc:398: // Android doesn't currently provide
mkdtemp
On 2012/08/10 00:13:47, asiva wrote:
> end comment with a "."

Done.

http://codereview.chromium.org/10826233/diff/1/runtime/bin/directory_android....
runtime/bin/directory_android.cc:399: static char* Mkdtemp(char* path_template)
{
On 2012/08/10 07:28:28, Søren Gjesse wrote:
> How about calling it MakeTempDirectory so that it is clear at the call site
that
> this is not a system call?

Done.

http://codereview.chromium.org/10826233/diff/1/runtime/bin/socket_android.cc
File runtime/bin/socket_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/bin/socket_android.cc#...
runtime/bin/socket_android.cc:127: int len = sizeof(errorNumber);
On 2012/08/10 00:13:47, asiva wrote:
> why not declare this as socklen_t
> i.e socklen_t len = ....;
> or have an assertion:
> sizeof(socklen_t) == sizeof(int);

Done.

http://codereview.chromium.org/10826233/diff/1/runtime/vm/gdbjit_android.cc
File runtime/vm/gdbjit_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/vm/gdbjit_android.cc#n...
runtime/vm/gdbjit_android.cc:3: // BSD-style license that can be found in the
LICENSE file.
On 2012/08/10 00:13:47, asiva wrote:
> Ditto comment.

Answering all 3 JIT-related comments:

I tried using gdb to debug Android Dart. It failed as follows:

Reading symbols from ...dart-repo/dart/out/ReleaseIA32/dart...done.
Unsupported JIT protocol version in descriptor!

So it looks like GDB JIT is not currently supported.

I'll remove these files for now, until I have time to investigate GDB support.

http://codereview.chromium.org/10826233/diff/1/runtime/vm/virtual_memory_andr...
File runtime/vm/virtual_memory_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/vm/virtual_memory_andr...
runtime/vm/virtual_memory_android.cc:29: // TODO(4408): use ashmem instead of
anonymous memory
On 2012/08/10 07:28:28, Søren Gjesse wrote:
> End comment with .

Done.

[cshapiro, 2012-08-14 01:24:06]

http://codereview.chromium.org/10826233/diff/1/runtime/vm/gdbjit_android.cc
File runtime/vm/gdbjit_android.cc (right):

http://codereview.chromium.org/10826233/diff/1/runtime/vm/gdbjit_android.cc#n...
runtime/vm/gdbjit_android.cc:3: // BSD-style license that can be found in the
LICENSE file.
What version of GDB are you using on the target?  They should all have JIT
support.  This message is often reported in error and if you restart the GDB
session it may go away.