Issue 10826216: Date formatting again with fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826216: Date formatting again with fixes (Closed)

Created:
8 years, 4 months ago by Alan Knight

Modified:
8 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Date formatting again with fixes Does not import intl.dart twice, and does not attempt to directly sort the keys of a map, which dartj2s does not like (issue 4421). Committed: https://code.google.com/p/dart/source/detail?r=10426

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+749 lines, -158 lines)			Patch
M	lib/i18n/date_format.dart	View	5 chunks	+406 lines, -141 lines	0 comments	Download
A +	lib/i18n/date_symbol_data.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/i18n/date_symbols.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/i18n/date_time_patterns.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	lib/i18n/intl.dart	View	6 chunks	+74 lines, -7 lines	0 comments	Download
A +	lib/i18n/lib/date_format_field.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/i18n/lib/date_format_helpers.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/lib/i18n/date_time_format_test.dart	View	1 chunk	+275 lines, -16 lines	1 comment	Download
A +	tests/lib/i18n/date_time_format_test_data.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/lib/i18n/intl_message_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/lib/i18n/intl_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

https://chromiumcodereview.appspot.com/10826216/diff/1/tests/lib/i18n/date_time_format_test.dart File tests/lib/i18n/date_time_format_test.dart (right): https://chromiumcodereview.appspot.com/10826216/diff/1/tests/lib/i18n/date_time_format_test.dart#newcode217 tests/lib/i18n/date_time_format_test.dart:217: // Workaround for a dartj2 issue that treats the ...

8 years, 4 months ago (2012-08-09 00:11:11 UTC) #2

Emily Fortuna

8 years, 4 months ago (2012-08-09 00:14:13 UTC) #3

lgtm! 
Will you file a bug about the dart2js issue? Seems like we should look into
fixing that, too.

Expand Messages | Collapse Messages