Issue 10826204: Revert "estimating parameter types" optimization due to failure on browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826204: Revert "estimating parameter types" optimization due to failure on browser (Closed)

Created:
8 years, 4 months ago by Søren Gjesse

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "estimating parameter types" optimization due to failure on browser test "samples/tests/samples/lib/view/view_test.dart" Revert "Collect call site information and use that for estimating parameter types" This reverts commit f0c42199df50d3d70a47d7ea7311b63b0e60cab0. Revert "Fix mistake in previous commit r10383" This reverts commit 571f6f3cdabecddecbeee9a0d3fca8b8c5ad61b0. TBR=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=10394

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -296 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	4 chunks	+0 lines, -113 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	3 chunks	+0 lines, -16 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/universe.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	tests/compiler/dart2js/call_site_type_inferer_test.dart	View	1 chunk	+0 lines, -151 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM :(((

Expand Messages | Collapse Messages