Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Issue 10826186: First take on support of library private names. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First take on support of library private names. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10367

Patch Set 1 #

Patch Set 2 : Better variant #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -28 lines) Patch
M lib/compiler/implementation/dart_backend/renamer.dart View 1 2 5 chunks +50 lines, -12 lines 0 comments Download
M lib/compiler/implementation/tree/unparser.dart View 3 chunks +8 lines, -11 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-08-07 15:34:35 UTC) #1
Roman
8 years, 4 months ago (2012-08-08 06:20:37 UTC) #2
lgtm

Please add comments that we only need to rename non-top-level private
definitions and their accessors.

Powered by Google App Engine
This is Rietveld 408576698