Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 10826116: Revert "Use platform-independent format specifiers when disassembling code objects." (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)
Modified:
8 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Use platform-independent format specifiers when disassembling code objects." This is still broken on Windows. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -54 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/platform/globals.h View 2 chunks +7 lines, -18 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +28 lines, -22 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 4 months ago (2012-08-02 15:51:49 UTC) #1
Florian Schneider
8 years, 4 months ago (2012-08-02 15:52:58 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698