Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10826086: Moved mock tests to regular tests. (Closed)

Created:
8 years, 4 months ago by gram
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added bad regexp callmatcher mock test. Committed: https://code.google.com/p/dart/source/detail?r=10088

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -0 lines) Patch
M tests/lib/lib.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/unittest/mock_regexp_negative_test.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
A tests/lib/unittest/mock_test.dart View 1 1 chunk +590 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
Separated out the new mock tests from other CL.
8 years, 4 months ago (2012-07-31 17:56:33 UTC) #1
gram
PTAL
8 years, 4 months ago (2012-07-31 18:12:07 UTC) #2
Siggi Cherem (dart-lang)
8 years, 4 months ago (2012-07-31 21:05:29 UTC) #3
very cool! thank you!
LGTM! STV! +1 :-)

Powered by Google App Engine
This is Rietveld 408576698