Issue 10826083: Properly rename new <class>.<factory> expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826083: Properly rename new <class>.<factory> expressions. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly rename new <class>.<factory> expressions. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10059

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	lib/compiler/implementation/dart_backend/renamer.dart	View		1 chunk	+2 lines, -5 lines	2 comments	Download
	M	tests/language/language.status	View		3 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10826083/diff/1/lib/compiler/implementation/dart_backend/renamer.dart File lib/compiler/implementation/dart_backend/renamer.dart (right): https://chromiumcodereview.appspot.com/10826083/diff/1/lib/compiler/implementation/dart_backend/renamer.dart#newcode38 lib/compiler/implementation/dart_backend/renamer.dart:38: } else if ((element.isGenerativeConstructor() || element.isFactoryConstructor()) >80 chars

8 years, 4 months ago (2012-07-31 14:28:39 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-07-31 15:05:04 UTC) #3

https://chromiumcodereview.appspot.com/10826083/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/10826083/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:38: } else if
((element.isGenerativeConstructor() || element.isFactoryConstructor())
On 2012/07/31 14:28:39, Roman wrote:
> >80 chars

Done.

Expand Messages | Collapse Messages